danny0405 commented on code in PR #12796:
URL: https://github.com/apache/hudi/pull/12796#discussion_r1960987499
##########
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/sink/bucket/ITTestBucketStreamWrite.java:
##########
@@ -78,10 +84,10 @@ public void
testBucketStreamWriteAfterRollbackFirstFileGroupCreation(boolean isC
// this test is to ensure that the correct fileId can be fetched when
recovering from a rollover when a new
// fileGroup is created for a bucketId
String tablePath = tempFile.getAbsolutePath();
- doWrite(tablePath, isCow);
- doDeleteCommit(tablePath, isCow);
- doWrite(tablePath, isCow);
- doWrite(tablePath, isCow);
+ doWrite(tablePath, isCow, 1, "upsert");
+ doDeleteCommit(tablePath);
+ doWrite(tablePath, isCow, 1, "upsert");
+ doWrite(tablePath, isCow, 1, "upsert");
Review Comment:
bucket index is always "upsert", do we have other options?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
