yihua commented on code in PR #12864:
URL: https://github.com/apache/hudi/pull/12864#discussion_r1968534554
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/schema/TestSchemaRegistryProvider.java:
##########
@@ -18,15 +18,14 @@
package org.apache.hudi.utilities.schema;
-import org.apache.hudi.common.config.TypedProperties;
-import org.apache.hudi.common.function.SerializableFunctionUnchecked;
-import org.apache.hudi.common.util.Option;
-
import io.confluent.kafka.schemaregistry.ParsedSchema;
import io.confluent.kafka.schemaregistry.client.SchemaMetadata;
import io.confluent.kafka.schemaregistry.client.SchemaRegistryClient;
import io.confluent.kafka.schemaregistry.client.rest.RestService;
import org.apache.avro.Schema;
+import org.apache.hudi.common.config.TypedProperties;
Review Comment:
Let's revert the changes and keep the import ordering.
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/sources/TestJsonKafkaSource.java:
##########
@@ -405,16 +459,41 @@ public void testAppendKafkaOffset() {
jsonSource = new JsonKafkaSource(props, jsc(), spark(), schemaProvider,
metrics);
kafkaSource = new SourceFormatAdapter(jsonSource);
Dataset<Row> dfWithOffsetInfoAndNullKafkaKey =
kafkaSource.fetchNewDataInRowFormat(Option.empty(),
Long.MAX_VALUE).getBatch().get().cache();
- // total of 2 * numMessages are in the topic at this point, half with a
key and half with a null key. All should have the source offset.
assertEquals(numMessages,
dfWithOffsetInfoAndNullKafkaKey.toDF().filter("_hoodie_kafka_source_key is
null").count());
- assertEquals(numMessages,
dfWithOffsetInfoAndNullKafkaKey.toDF().filter("_hoodie_kafka_source_key is not
null").count());
- assertEquals(numMessages * 2,
dfWithOffsetInfoAndNullKafkaKey.toDF().filter("_hoodie_kafka_source_offset is
not null").count());
Review Comment:
We should keep these lines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
