yihua commented on code in PR #12864:
URL: https://github.com/apache/hudi/pull/12864#discussion_r1968551736
##########
hudi-utilities/pom.xml:
##########
@@ -374,18 +381,28 @@
<dependency>
<groupId>io.confluent</groupId>
<artifactId>kafka-schema-registry-client</artifactId>
+ <version>${confluent.version}</version>
</dependency>
<dependency>
<groupId>io.confluent</groupId>
<artifactId>kafka-protobuf-serializer</artifactId>
+ <version>${confluent.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>com.kjetland</groupId>
+
<artifactId>mbknor-jackson-jsonschema_${scala.binary.version}</artifactId>
</dependency>
<dependency>
<groupId>io.confluent</groupId>
<artifactId>kafka-json-schema-serializer</artifactId>
+ <version>${confluent.version}</version>
Review Comment:
Same here.
##########
hudi-utilities/pom.xml:
##########
@@ -374,18 +381,28 @@
<dependency>
<groupId>io.confluent</groupId>
<artifactId>kafka-schema-registry-client</artifactId>
+ <version>${confluent.version}</version>
</dependency>
<dependency>
<groupId>io.confluent</groupId>
<artifactId>kafka-protobuf-serializer</artifactId>
+ <version>${confluent.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>com.kjetland</groupId>
+
<artifactId>mbknor-jackson-jsonschema_${scala.binary.version}</artifactId>
</dependency>
<dependency>
<groupId>io.confluent</groupId>
<artifactId>kafka-json-schema-serializer</artifactId>
+ <version>${confluent.version}</version>
</dependency>
+
<dependency>
- <groupId>com.kjetland</groupId>
-
<artifactId>mbknor-jackson-jsonschema_${scala.binary.version}</artifactId>
+ <groupId>org.apache.kafka</groupId>
+ <artifactId>kafka-streams-test-utils</artifactId>
+ <version>3.4.0</version>
Review Comment:
Let's define the dependency and version in the root POM and remove the
version here.
##########
hudi-utilities/pom.xml:
##########
@@ -361,10 +366,12 @@
<dependency>
<groupId>io.confluent</groupId>
<artifactId>kafka-avro-serializer</artifactId>
+ <version>${confluent.version}</version>
Review Comment:
The version is already defined in the root POM so there is no need to do it
in the `hudi-utilities`'s POM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
