yihua commented on code in PR #12843:
URL: https://github.com/apache/hudi/pull/12843#discussion_r1978416459
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/BaseHoodieFileGroupRecordBuffer.java:
##########
@@ -72,13 +72,15 @@
import static
org.apache.hudi.common.config.HoodieMemoryConfig.SPILLABLE_MAP_BASE_PATH;
import static
org.apache.hudi.common.engine.HoodieReaderContext.INTERNAL_META_PARTITION_PATH;
import static
org.apache.hudi.common.engine.HoodieReaderContext.INTERNAL_META_RECORD_KEY;
+import static
org.apache.hudi.common.model.DefaultHoodieRecordPayload.DELETE_KEY;
+import static
org.apache.hudi.common.model.DefaultHoodieRecordPayload.DELETE_MARKER;
import static org.apache.hudi.common.model.HoodieRecord.DEFAULT_ORDERING_VALUE;
import static
org.apache.hudi.common.model.HoodieRecord.HOODIE_IS_DELETED_FIELD;
import static
org.apache.hudi.common.model.HoodieRecord.OPERATION_METADATA_FIELD;
import static
org.apache.hudi.common.model.HoodieRecordMerger.PAYLOAD_BASED_MERGE_STRATEGY_UUID;
import static
org.apache.hudi.common.table.log.block.HoodieLogBlock.HeaderMetadataType.INSTANT_TIME;
-public abstract class HoodieBaseFileGroupRecordBuffer<T> implements
HoodieFileGroupRecordBuffer<T> {
+public abstract class BaseHoodieFileGroupRecordBuffer<T> implements
HoodieFileGroupRecordBuffer<T> {
Review Comment:
For simplicity we can name this class as `FileGroupRecordBuffer`
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/KeyBasedHoodieFileGroupRecordBuffer.java:
##########
@@ -40,15 +41,18 @@
import java.util.Iterator;
import java.util.Map;
+import static
org.apache.hudi.common.engine.HoodieReaderContext.INTERNAL_META_PARTITION_PATH;
+import static
org.apache.hudi.common.engine.HoodieReaderContext.INTERNAL_META_RECORD_KEY;
+
/**
* A buffer that is used to store log records by {@link
org.apache.hudi.common.table.log.HoodieMergedLogRecordReader}
* by calling the {@link #processDataBlock} and {@link #processDeleteBlock}
methods into a record key based map.
* The records from the base file is accessed from an iterator object. These
records are merged when the
* {@link #hasNext} method is called.
*/
-public class HoodieKeyBasedFileGroupRecordBuffer<T> extends
HoodieBaseFileGroupRecordBuffer<T> {
+public class KeyBasedHoodieFileGroupRecordBuffer<T> extends
BaseHoodieFileGroupRecordBuffer<T> {
Review Comment:
Similarly, remove `Hoodie` in the class name for simplicity
```suggestion
public class KeyBasedFileGroupRecordBuffer<T> extends
BaseHoodieFileGroupRecordBuffer<T> {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
