yihua commented on code in PR #12843:
URL: https://github.com/apache/hudi/pull/12843#discussion_r1999295986
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/KeyBasedFileGroupRecordBuffer.java:
##########
@@ -82,7 +86,12 @@ public void processDataBlock(HoodieDataBlock dataBlock,
Option<KeySpec> keySpecO
Map<String, Object> metadata = readerContext.generateMetadataForRecord(
nextRecord, schema);
String recordKey = (String)
metadata.get(HoodieReaderContext.INTERNAL_META_RECORD_KEY);
- processNextDataRecord(nextRecord, metadata, recordKey);
+
+ if (shouldCheckCustomDeleteMarker && isCustomDeleteRecord(nextRecord))
{
Review Comment:
Could you move all delete checks here including the `_hoodie_is_deleted`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
