linliu-code commented on code in PR #12866:
URL: https://github.com/apache/hudi/pull/12866#discussion_r1980415147
##########
hudi-io/src/main/java/org/apache/hudi/io/hfile/HFileContext.java:
##########
@@ -29,37 +29,50 @@
public class HFileContext {
private final CompressionCodec compressionCodec;
private final HoodieDecompressor decompressor;
+ private final int blockSize;
- private HFileContext(CompressionCodec compressionCodec) {
+ private HFileContext(CompressionCodec compressionCodec, int blockSize) {
this.compressionCodec = compressionCodec;
this.decompressor =
HoodieDecompressorFactory.getDecompressor(compressionCodec);
+ this.blockSize = blockSize;
}
- CompressionCodec getCompressionCodec() {
+ public CompressionCodec getCompressionCodec() {
return compressionCodec;
}
- HoodieDecompressor getDecompressor() {
+ public HoodieDecompressor getDecompressor() {
return decompressor;
}
+ public int getBlockSize() {
+ return blockSize;
+ }
+
public static Builder builder() {
return new Builder();
}
+ // TODO: Add all necessary fileds as HBASE HFileContext.
Review Comment:
Maybe remove it actually since it should be sufficient for Hudi.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
