linliu-code commented on code in PR #12866:
URL: https://github.com/apache/hudi/pull/12866#discussion_r1980441124
##########
hudi-hadoop-common/src/main/java/org/apache/hudi/common/util/HFileUtils.java:
##########
@@ -207,25 +194,21 @@ public byte[] serializeRecordsToLogBlock(HoodieStorage
storage,
sortedRecordsMap.put(recordKey, recordBytesList);
}
- HFile.Writer writer = HFile.getWriterFactory(conf, cacheConfig)
- .withOutputStream(ostream).withFileContext(context).create();
-
- // Write the records
+ HFileContext context = HFileContext.builder().build();
+ HFileWriter writer = new HFileWriterImpl(context, ostream);
sortedRecordsMap.forEach((recordKey, recordBytesList) -> {
for (byte[] recordBytes : recordBytesList) {
try {
- KeyValue kv = new KeyValue(recordKey.getBytes(), null, null,
recordBytes);
- writer.append(kv);
+ writer.append(recordKey.getBytes(StandardCharsets.UTF_8),
recordBytes);
} catch (IOException e) {
throw new HoodieIOException("IOException serializing records", e);
}
}
});
-
writer.appendFileInfo(
- getUTF8Bytes(HoodieAvroHFileReaderImplBase.SCHEMA_KEY),
getUTF8Bytes(readerSchema.toString()));
-
+ HoodieAvroHFileReaderImplBase.SCHEMA_KEY,
getUTF8Bytes(readerSchema.toString()));
Review Comment:
No, I changed the api for the writer a bit, to make it a bit easier to read.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
