yihua commented on code in PR #12919:
URL: https://github.com/apache/hudi/pull/12919#discussion_r1982711030
##########
hudi-common/src/main/java/org/apache/hudi/index/expression/HoodieExpressionIndex.java:
##########
@@ -47,6 +47,10 @@ public interface HoodieExpressionIndex<S, T> extends
Serializable {
String DAYS_OPTION = "days";
String FORMAT_OPTION = "format";
String IDENTITY_TRANSFORM = "identity";
+ // Bloom filter options
+ String BLOOM_FILTER_TYPE = "filterType";
+ String BLOOM_FILTER_NUM_ENTRIES = "numEntries";
+ String FALSE_POSITIVE_RATE = "fpp";
Review Comment:
Should we avoid case sensitivity and only use lower case letters in the
option names?
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/feature/index/TestExpressionIndex.scala:
##########
@@ -1776,7 +1776,7 @@ class TestExpressionIndex extends HoodieSparkSqlTestBase {
|""".stripMargin)
// create index using bloom filters on city column with upper()
function
- spark.sql(s"create index idx_bloom_$tableName on $tableName using
bloom_filters(city) options(expr='upper')")
+ spark.sql(s"create index idx_bloom_$tableName on $tableName using
bloom_filters(city) options(expr='upper', fpp='0.01')")
Review Comment:
Should we test all options? Could you add validation on these params so
that they are stored in the index definition and actually take effect?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
