codope commented on code in PR #12919:
URL: https://github.com/apache/hudi/pull/12919#discussion_r1983527764
##########
hudi-common/src/main/java/org/apache/hudi/index/expression/HoodieExpressionIndex.java:
##########
@@ -47,6 +47,10 @@ public interface HoodieExpressionIndex<S, T> extends
Serializable {
String DAYS_OPTION = "days";
String FORMAT_OPTION = "format";
String IDENTITY_TRANSFORM = "identity";
+ // Bloom filter options
+ String BLOOM_FILTER_TYPE = "filterType";
+ String BLOOM_FILTER_NUM_ENTRIES = "numEntries";
+ String FALSE_POSITIVE_RATE = "fpp";
Review Comment:
Don't have a string preference. I just thought it's easy to read with camel
case. Do we have a convention? I can change if so.
##########
hudi-common/src/main/java/org/apache/hudi/index/expression/HoodieExpressionIndex.java:
##########
@@ -47,6 +47,10 @@ public interface HoodieExpressionIndex<S, T> extends
Serializable {
String DAYS_OPTION = "days";
String FORMAT_OPTION = "format";
String IDENTITY_TRANSFORM = "identity";
+ // Bloom filter options
+ String BLOOM_FILTER_TYPE = "filterType";
+ String BLOOM_FILTER_NUM_ENTRIES = "numEntries";
+ String FALSE_POSITIVE_RATE = "fpp";
Review Comment:
Don't have a strong preference. I just thought it's easy to read with camel
case. Do we have a convention? I can change if so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
