yihua commented on code in PR #12935:
URL: https://github.com/apache/hudi/pull/12935#discussion_r1987972310
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/HoodieFileGroupReader.java:
##########
@@ -112,6 +112,7 @@ public HoodieFileGroupReader(HoodieReaderContext<T>
readerContext,
mergeStrategyId, null, tableConfig.getTableVersion());
recordMergeMode = triple.getLeft();
mergeStrategyId = triple.getRight();
+ tableConfig.setValue(HoodieTableConfig.RECORD_MERGE_MODE.key(),
recordMergeMode.name());
Review Comment:
If the record merge mode is needed, could we put this into a common place,
e.g., `getRecordMergeMode()` or initializing the table config by inferring
merge mode and serving that from the table config instance (check
`HoodieTableConfig#inferCorrectMergingBehavior`)?
##########
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/realtime/HoodieCombineRealtimeRecordReader.java:
##########
@@ -54,8 +54,8 @@ public class HoodieCombineRealtimeRecordReader implements
RecordReader<NullWrita
public HoodieCombineRealtimeRecordReader(JobConf jobConf, CombineFileSplit
split,
List<RecordReader> readers) {
+ useFileGroupReader = shouldUseFilegroupReader(jobConf, split);
Review Comment:
will this fail?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
