yihua commented on code in PR #12935:
URL: https://github.com/apache/hudi/pull/12935#discussion_r1987874645
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/HoodieBaseFileGroupRecordBuffer.java:
##########
@@ -424,8 +424,10 @@ protected Option<T> merge(Option<T> older, Map<String,
Object> olderInfoMap,
}
Comparable oldOrderingValue = readerContext.getOrderingValue(
older, olderInfoMap, readerSchema, orderingFieldName);
- if (!isDeleteRecordWithNaturalOrder(older, oldOrderingValue)
- && oldOrderingValue.compareTo(newOrderingValue) > 0) {
+ boolean choosePrev = !oldOrderingValue.equals(0)
+ && ReflectionUtils.isSameClass(oldOrderingValue,
newOrderingValue)
Review Comment:
`DEFAULT_ORDERING_VALUE` is specific for commit time ordering and should
only be used by deletes without ordering value specified. We should check if
we need to add additional check for non-deletes if the such an ordering value
is used. Could you point out which test failed without the fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
