danny0405 commented on code in PR #12949:
URL: https://github.com/apache/hudi/pull/12949#discussion_r1988194545
##########
hudi-common/src/test/java/org/apache/hudi/common/util/TestSerializableSchema.java:
##########
@@ -58,7 +58,7 @@ public void testLargeSchema() throws IOException {
private void verifySchema(Schema schema) throws IOException {
SerializableSchema serializableSchema = new SerializableSchema(schema);
assertEquals(schema, serializableSchema.get());
- assertTrue(schema != serializableSchema.get());
Review Comment:
The deserialized schema should never have the same reference with the
original schema, we should make the test pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]