danny0405 commented on code in PR #12949:
URL: https://github.com/apache/hudi/pull/12949#discussion_r1988195780


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieAppendHandle.java:
##########
@@ -153,7 +154,7 @@ public HoodieAppendHandle(HoodieWriteConfig config, String 
instantTime, HoodieTa
             // When enabling writing partial updates to the data blocks in log 
files,
             // i.e., partial update schema is set, the writer schema is the 
partial
             // schema containing the updated fields only
-            ? Option.of(new 
Schema.Parser().parse(config.getPartialUpdateSchema()))
+            ? 
Option.of(AvroSchemaUtils.parseSchemaFromStr(config.getPartialUpdateSchema()))

Review Comment:
   Move the method to `AvroSchemaCache` and rename it to just 
`AvroSchemaCache#getAvroSchema`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to