danny0405 commented on code in PR #12948:
URL: https://github.com/apache/hudi/pull/12948#discussion_r1990376967
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/BaseTableServicePlanActionExecutor.java:
##########
@@ -124,7 +124,9 @@ public Pair<Option<HoodieInstant>, Set<String>>
getIncrementalPartitions(TableSe
.filter(this::filterCommitByTableType).flatMap(instant -> {
try {
String completionTime = instant.getCompletionTime();
- if (completionTime.compareTo(leftBoundary) >= 0 &&
completionTime.compareTo(rightBoundary) < 0) {
+ if (completionTime.compareTo(leftBoundary) >= 0
+ && ((instant.requestedTime().length() <
completionTime.length() && instant.requestedTime().compareTo(rightBoundary) < 0)
Review Comment:
This line is confusing, can we at least add a comment, or maybe abstract it
as a separate method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
