danny0405 commented on code in PR #12948: URL: https://github.com/apache/hudi/pull/12948#discussion_r1992518339
########## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java: ########## @@ -155,6 +160,8 @@ public abstract class HoodieBackedTableMetadataWriter<I> implements HoodieTableM protected StorageConfiguration<?> storageConf; protected final transient HoodieEngineContext engineContext; protected final List<MetadataPartitionType> enabledPartitionTypes; + protected final MetadataWriteHandler metadataWriteHandler; Review Comment: I feel like maybe we just sub-class the whole `HoodieBackedTableMetadataWriter` instead of introducing `MetadataWriteHandler` on existing code, this makes the code clean and more easier to remove the legacys in the future. Like what we do to the timeline and completion time query view. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
