nsivabalan commented on code in PR #12948: URL: https://github.com/apache/hudi/pull/12948#discussion_r1997508520
########## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java: ########## @@ -155,6 +160,8 @@ public abstract class HoodieBackedTableMetadataWriter<I> implements HoodieTableM protected StorageConfiguration<?> storageConf; protected final transient HoodieEngineContext engineContext; protected final List<MetadataPartitionType> enabledPartitionTypes; + protected final MetadataWriteHandler metadataWriteHandler; Review Comment: yeah, we also wanted to do that. but due to our hierarchy, we could not come up w/ an elegant way to do that. bcoz, we have HoodieBackedTableMetadatWriter. and Flink, Java and SparkBackedTableMetadatWriter extends from this. So, not easy to make entire class HoodieBackedTableMetadatWriter as V1 and V2. So, we went w/ introducing a new write handler internally within HoodieBackedTableMetadatWriter. Let us know if you have better ideas. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
