lokeshj1703 commented on code in PR #12948:
URL: https://github.com/apache/hudi/pull/12948#discussion_r1995091173
##########
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/realtime/HoodieCombineRealtimeRecordReader.java:
##########
@@ -54,8 +54,8 @@ public class HoodieCombineRealtimeRecordReader implements
RecordReader<NullWrita
public HoodieCombineRealtimeRecordReader(JobConf jobConf, CombineFileSplit
split,
List<RecordReader> readers) {
+ useFileGroupReader = shouldUseFilegroupReader(jobConf, split);
Review Comment:
Not part of this PR. Removed it.
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/HoodieBaseFileGroupRecordBuffer.java:
##########
@@ -424,8 +424,10 @@ protected Option<T> merge(Option<T> older, Map<String,
Object> olderInfoMap,
}
Comparable oldOrderingValue = readerContext.getOrderingValue(
older, olderInfoMap, readerSchema, orderingFieldName);
- if (!isDeleteRecordWithNaturalOrder(older, oldOrderingValue)
- && oldOrderingValue.compareTo(newOrderingValue) > 0) {
+ boolean choosePrev = !oldOrderingValue.equals(0)
+ && ReflectionUtils.isSameClass(oldOrderingValue,
newOrderingValue)
Review Comment:
Not part of this PR. Removed it.
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/SparkBroadcastManager.java:
##########
@@ -116,10 +119,8 @@ public Option<HoodieReaderContext>
retrieveFileGroupReaderContext(StoragePath ba
SparkParquetReader sparkParquetReader = parquetReaderBroadcast.getValue();
if (sparkParquetReader != null) {
List<Filter> filters = new ArrayList<>();
- return Option.of(new SparkFileFormatInternalRowReaderContext(
- sparkParquetReader,
- JavaConverters.asScalaBufferConverter(filters).asScala().toSeq(),
- JavaConverters.asScalaBufferConverter(filters).asScala().toSeq()));
+ return Option.of(new
SparkFileFormatInternalRowReaderContext(sparkParquetReader,
JavaConverters.asScalaBufferConverter(filters).asScala().toSeq(),
Review Comment:
Not part of this PR. Removed it.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/BaseTableServicePlanActionExecutor.java:
##########
@@ -124,7 +124,9 @@ public Pair<Option<HoodieInstant>, Set<String>>
getIncrementalPartitions(TableSe
.filter(this::filterCommitByTableType).flatMap(instant -> {
try {
String completionTime = instant.getCompletionTime();
- if (completionTime.compareTo(leftBoundary) >= 0 &&
completionTime.compareTo(rightBoundary) < 0) {
+ if (completionTime.compareTo(leftBoundary) >= 0
+ && ((instant.requestedTime().length() <
completionTime.length() && instant.requestedTime().compareTo(rightBoundary) < 0)
Review Comment:
Not part of this PR. Removed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
