yihua commented on code in PR #12987:
URL: https://github.com/apache/hudi/pull/12987#discussion_r1999724663
##########
hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/client/TestHoodieClientMultiWriter.java:
##########
@@ -834,11 +843,12 @@ public void
testMultiWriterWithAsyncTableServicesWithConflict(HoodieTableType ta
// Since the concurrent modifications went in, this upsert has
// to fail
assertThrows(HoodieWriteConflictException.class, () -> {
- createCommitWithUpserts(cfg, client1, thirdCommitTime,
Option.of(commitTimeBetweenPrevAndNew), newCommitTime, numRecords);
+ createCommitWithUpserts(cfg, client1, thirdCommitTime,
Option.of(commitTimeBetweenPrevAndNew), upsertCommitTime, numRecords);
});
} else {
// We don't have the compaction for COW and so this upsert
// has to pass
+ final String newCommitTime = client1.createNewInstantTime();
Review Comment:
Could we add the validation on the precondition you mentioned in the PR
description so the test should error out earlier with clear message?
##########
hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/client/TestHoodieClientMultiWriter.java:
##########
@@ -746,9 +735,27 @@ private void latchCountDownAndWait(CountDownLatch latch,
long waitTimeMillis) {
}
}
- @ParameterizedTest
- @MethodSource("providerClassResolutionStrategyAndTableType")
- public void
testMultiWriterWithAsyncTableServicesWithConflict(HoodieTableType tableType,
Class<? extends LockProvider<?>> providerClass,
Review Comment:
Let's keep the original code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
