danny0405 commented on code in PR #12967:
URL: https://github.com/apache/hudi/pull/12967#discussion_r2004625488
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/util/FlinkWriteClients.java:
##########
@@ -213,6 +213,7 @@ public static HoodieWriteConfig getHoodieClientConfig(
.parquetBlockSize(conf.getInteger(FlinkOptions.WRITE_PARQUET_BLOCK_SIZE) * 1024
* 1024)
.parquetPageSize(conf.getInteger(FlinkOptions.WRITE_PARQUET_PAGE_SIZE) * 1024 *
1024)
.parquetMaxFileSize(conf.getInteger(FlinkOptions.WRITE_PARQUET_MAX_FILE_SIZE) *
1024 * 1024L)
+
.withWriteUtcTimezone(conf.get(FlinkOptions.WRITE_UTC_TIMEZONE))
Review Comment:
Not sure if it can be generalized among engins, it is also very related with
the reader behaviors.
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/util/FlinkWriteClients.java:
##########
@@ -213,6 +213,7 @@ public static HoodieWriteConfig getHoodieClientConfig(
.parquetBlockSize(conf.getInteger(FlinkOptions.WRITE_PARQUET_BLOCK_SIZE) * 1024
* 1024)
.parquetPageSize(conf.getInteger(FlinkOptions.WRITE_PARQUET_PAGE_SIZE) * 1024 *
1024)
.parquetMaxFileSize(conf.getInteger(FlinkOptions.WRITE_PARQUET_MAX_FILE_SIZE) *
1024 * 1024L)
+
.withWriteUtcTimezone(conf.get(FlinkOptions.WRITE_UTC_TIMEZONE))
Review Comment:
Not sure if it can be generalized among engines, it is also very related
with the reader behaviors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
