cshuo commented on PR #12967: URL: https://github.com/apache/hudi/pull/12967#issuecomment-2739342070
> Hello, guys. I have tested performance and results are good for this patch. I didn't found performance problems with usage of HandleRecords, but agree it's better to use iterator itself. Will try to continue review today, but in general design looks good. > > Also I'm testing performance with enabled sorting, will share results in RFC pr #12960 Thanks @Alowator for the performance testing. > Hello, guys. I have tested performance and results are good for this patch. I didn't found performance problems with usage of HandleRecords, but agree it's better to use iterator itself. Will try to continue review today, but in general design looks good. > > Also I'm testing performance with enabled sorting, will share results in RFC pr #12960 Thanks @Alowator for the performance testing 🎉. `HandleRecords` is actually removed for sake of neat API design. And for sorting, I've also add new comments in https://github.com/apache/hudi/pull/12960. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
