yihua commented on code in PR #12843:
URL: https://github.com/apache/hudi/pull/12843#discussion_r2012539863
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/FileGroupRecordBuffer.java:
##########
@@ -244,8 +280,7 @@ protected Option<Pair<Option<T>, Map<String, Object>>>
doProcessNextDataRecord(T
Comparable incomingOrderingValue = readerContext.getOrderingValue(
Option.of(record), metadata, readerSchema, orderingFieldName);
if (incomingOrderingValue.compareTo(existingOrderingValue) > 0) {
- return Option.of(Pair.of(isDeleteRecord(Option.of(record),
readerContext.getSchemaFromMetadata(metadata))
- ? Option.empty() : Option.of(record), metadata));
+ return Option.of(Pair.of(Option.of(record), metadata));
Review Comment:
No. We consolidated the delete handling as you suggested before so that all
types of delete records are handled by
`KeyBasedFileGroupRecordBuffer#processDeleteRecord` and
`#processNextDeletedRecord`. This method only handles non-deletes so there is
no need to check whether the record is a delete or not I this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
