linliu-code commented on code in PR #12843:
URL: https://github.com/apache/hudi/pull/12843#discussion_r2004322820
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/PositionBasedFileGroupRecordBuffer.java:
##########
@@ -135,13 +137,13 @@ public void processDataBlock(HoodieDataBlock dataBlock,
Option<KeySpec> keySpecO
}
long recordPosition = recordPositions.get(recordIndex++);
-
T evolvedNextRecord =
schemaTransformerWithEvolvedSchema.getLeft().apply(nextRecord);
- processNextDataRecord(
- evolvedNextRecord,
- readerContext.generateMetadataForRecord(evolvedNextRecord, schema),
- recordPosition
- );
+ Map<String, Object> metadata =
readerContext.generateMetadataForRecord(evolvedNextRecord, schema);
+ if (shouldCheckCustomDeleteMarker &&
isCustomDeleteRecord(evolvedNextRecord)) {
+ processCustomDeleteRecord(evolvedNextRecord, metadata,
recordPosition);
Review Comment:
I have made some change to the Event time ordering. For CUSTOM, no obvious
change. But I do have some ideas to validate or simplify the logic of these
doProcessNextDataRecord logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
