nsivabalan commented on code in PR #13007:
URL: https://github.com/apache/hudi/pull/13007#discussion_r2007000236
##########
hudi-hadoop-common/src/test/java/org/apache/hudi/common/testutils/HoodieTestTable.java:
##########
@@ -754,6 +754,11 @@ public HoodieTestTable withLogMarkerFile(String
partitionPath, String fileName)
return this;
}
+ // public HoodieTestTable withLogMarkerFile(String partitionPath, String
fileId, IOType ioType) throws IOException {
Review Comment:
why commented out?
##########
hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/client/functional/TestHoodieBackedMetadata.java:
##########
@@ -258,6 +259,7 @@ public void testMetadataTableBootstrap(HoodieTableType
tableType, boolean addRol
validateMetadata(testTable, true);
}
+ @Disabled("HUDI-9221")
Review Comment:
we might need to investigate and re-enable these tests.
##########
hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/table/functional/TestHoodieSparkRollback.java:
##########
@@ -111,14 +113,19 @@ protected HoodieWriteConfig
getConfigToTestMDTRollbacks(Boolean autoCommit, Bool
.withRollbackUsingMarkers(true)
.withMetadataConfig(HoodieMetadataConfig.newBuilder().enable(mdtEnable).build())
.build();
+ cfg.setValue(HoodieWriteConfig.WRITE_TABLE_VERSION, "6");
+ return cfg;
}
/**
* Scenario: data table is updated, no changes to MDT
*/
protected void testRollbackWithFailurePreMDT(HoodieTableType tableType)
throws Exception {
initBasePath();
- HoodieTableMetaClient metaClient = getHoodieMetaClient(tableType);
+ TypedProperties props = new TypedProperties();
Review Comment:
can we add a validation at the end of every test to confirm that table
config -> table version is 6.
##########
hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/table/functional/TestHoodieSparkRollback.java:
##########
@@ -100,7 +102,7 @@ protected HoodieWriteConfig
getConfigToTestMDTRollbacks(Boolean autoCommit) {
}
protected HoodieWriteConfig getConfigToTestMDTRollbacks(Boolean autoCommit,
Boolean mdtEnable) {
- return HoodieWriteConfig.newBuilder()
Review Comment:
if this entire class is meant for table version 6, can we rename the test
class accordingly.
##########
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/table/action/rollback/TestMarkerBasedRollbackStrategy.java:
##########
@@ -141,7 +141,7 @@ private Map<String, Long>
createLogFilesAndMarkersToRollback(String partition,
} catch (IOException e) {
throw new RuntimeException(e);
}
- }).collect(Collectors.toMap(Function.identity(), e -> 1L));
Review Comment:
why flipping the size here? should we expect the size to be non 0 somewhere
down the line and hence we added 1 as length here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
