danny0405 commented on code in PR #13007:
URL: https://github.com/apache/hudi/pull/13007#discussion_r2013079596
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/MarkerBasedRollbackStrategy.java:
##########
@@ -173,11 +173,34 @@ protected HoodieRollbackRequest
createRollbackRequestForAppend(String fileId,
}
} else {
HoodieLogFile logFileToRollback = new HoodieLogFile(fullFilePath);
- // this is actually the base commit time for tableVersion < 8.
+ fileId = logFileToRollback.getFileId();
+ // For tbl version 6, deltaCommitTime is the commit time of the base
file for the file slice
baseCommitTime = logFileToRollback.getDeltaCommitTime();
- // NOTE: We don't strictly need the exact size, but this size needs to
be positive to pass metadata payload validation.
- // Therefore, we simply stub this value (1L), instead of doing a
fs call to get the exact size.
- logBlocksToBeDeleted =
Collections.singletonMap(logFileToRollback.getPath().getName(), 1L);
+ try {
+ StoragePathInfo pathInfo =
table.getMetaClient().getStorage().getPathInfo(logFileToRollback.getPath());
+ if (pathInfo != null) {
+ if (baseCommitTime.equals(instantToRollback.requestedTime())) {
Review Comment:
shell we add a table version check here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
