lokeshj1703 commented on code in PR #13007:
URL: https://github.com/apache/hudi/pull/13007#discussion_r2013575991
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -269,30 +270,35 @@ public boolean commitStats(String instantTime,
List<HoodieWriteStat> stats,
return true;
}
+ protected HoodieCommitMetadata reconcileCommitMetadata(HoodieTable table,
String commitActionType, String instantTime, HoodieCommitMetadata
originalMetadata) {
Review Comment:
The `reconcileMetadataForMissingFiles` is being used in other methods as
well. I have restructured in a similar way. PTAL.
##########
hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/table/functional/TestHoodieSparkRollback.java:
##########
@@ -111,14 +113,19 @@ protected HoodieWriteConfig
getConfigToTestMDTRollbacks(Boolean autoCommit, Bool
.withRollbackUsingMarkers(true)
.withMetadataConfig(HoodieMetadataConfig.newBuilder().enable(mdtEnable).build())
.build();
+ cfg.setValue(HoodieWriteConfig.WRITE_TABLE_VERSION, "6");
+ return cfg;
}
/**
* Scenario: data table is updated, no changes to MDT
*/
protected void testRollbackWithFailurePreMDT(HoodieTableType tableType)
throws Exception {
initBasePath();
- HoodieTableMetaClient metaClient = getHoodieMetaClient(tableType);
+ TypedProperties props = new TypedProperties();
Review Comment:
Addressed
##########
hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/table/functional/TestHoodieSparkRollback.java:
##########
@@ -100,7 +102,7 @@ protected HoodieWriteConfig
getConfigToTestMDTRollbacks(Boolean autoCommit) {
}
protected HoodieWriteConfig getConfigToTestMDTRollbacks(Boolean autoCommit,
Boolean mdtEnable) {
- return HoodieWriteConfig.newBuilder()
Review Comment:
Addressed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
