nsivabalan commented on code in PR #13007:
URL: https://github.com/apache/hudi/pull/13007#discussion_r2017623580
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/commit/BaseCommitActionExecutor.java:
##########
@@ -226,6 +226,7 @@ protected void commit(HoodieWriteMetadata<O> result,
List<HoodieWriteStat> write
try {
HoodieActiveTimeline activeTimeline = table.getActiveTimeline();
HoodieCommitMetadata metadata = result.getCommitMetadata().get();
+ metadata = appendMetadataForMissingFiles(metadata);
Review Comment:
yes.
```
@Override
protected HoodieCommitMetadata
appendMetadataForMissingFiles(HoodieCommitMetadata commitMetadata) throws
IOException {
if
(table.getMetaClient().getTableConfig().getTableVersion().greaterThanOrEquals(HoodieTableVersion.EIGHT))
{
// reconciliation not required for table version 8 and above.
return commitMetadata;
} else {
return CommitMetadataUtils.reconcileMetadataForMissingFiles(table,
getCommitActionType(), instantTime, commitMetadata,
config, context, storageConf, this.getClass().getSimpleName());
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
