yihua commented on code in PR #13007:
URL: https://github.com/apache/hudi/pull/13007#discussion_r2017623520
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -230,10 +230,11 @@ public boolean commitStats(String instantTime,
List<HoodieWriteStat> stats,
LOG.info("Committing " + instantTime + " action " + commitActionType);
// Create a Hoodie table which encapsulated the commits and files visible
HoodieTable table = createTable(config);
- HoodieCommitMetadata metadata = CommitUtils.buildMetadata(stats,
partitionToReplaceFileIds,
+ HoodieCommitMetadata oriMetadata = CommitUtils.buildMetadata(stats,
partitionToReplaceFileIds,
extraMetadata, operationType, config.getWriteSchema(),
commitActionType);
HoodieInstant inflightInstant =
table.getMetaClient().createNewInstant(State.INFLIGHT, commitActionType,
instantTime);
HeartbeatUtils.abortIfHeartbeatExpired(instantTime, table,
heartbeatClient, config);
+ HoodieCommitMetadata metadata = reconcileMetadata(table, commitActionType,
instantTime, oriMetadata);
Review Comment:
Should calling `reconcileMetadata` as part of `CommitUtils.buildMetadata`
which all callers should do? What's the reason of only doing this differently
in `commitStats`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
