nsivabalan commented on code in PR #13064:
URL: https://github.com/apache/hudi/pull/13064#discussion_r2027195711
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/HoodieTable.java:
##########
@@ -666,7 +670,7 @@ private void rollbackInflightInstant(HoodieInstant
inflightInstant,
-> entry.getRollbackInstant().getTimestamp())
.orElseGet(HoodieActiveTimeline::createNewInstantTime);
scheduleRollback(context, commitTime, inflightInstant, false,
config.shouldRollbackUsingMarkers(),
- false);
+ false, false);
Review Comment:
for rollbacks, we can do that. but for cleaning, we just need it for
timestamp validation. So, it increases the locking granularity. entire planning
will be under a lock :(
and esply clean planning could involve non-trivial amount of time, we are
trying not to take locks for entire planning phase.
Ideally, if we standardize any planning to be under lock, all this will
smoothen out. but locking is also costly. so, we don't wanna take locks just
for code maintenance/structuring purpose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
