nsivabalan commented on code in PR #13064:
URL: https://github.com/apache/hudi/pull/13064#discussion_r2029434376
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/clean/CleanPlanActionExecutor.java:
##########
@@ -192,6 +198,19 @@ protected Option<HoodieCleanerPlan> requestClean(String
startCleanTime) {
return option;
}
+ private void validateForLatestTimestamp(HoodieInstant cleanInstant) {
+ try {
+ if (!skipLocking) {
+ txnManager.beginTransaction(Option.of(cleanInstant), Option.empty());
+ }
+ table.validateForLatestTimestamp(cleanInstant.getTimestamp());
+ } finally {
+ if (!skipLocking) {
Review Comment:
timestamp validation is just to ensure the timestamp chosen for this
cleaning is higher than all other timestamps generated so far (based in the
timeline).
So, does not mean concurrent cleaning.
We could have had a concurrent compaction instant which got added to
timeline just around the same time clean instant generation happened, but has
higher timestamp compared to this clean instant. Just that the clean planning
took non trivial amount of time during which, the compaction plan was added to
the timeline
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
