the-other-tim-brown commented on code in PR #12982:
URL: https://github.com/apache/hudi/pull/12982#discussion_r2025880240
##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/HoodieTableFileSystemView.java:
##########
@@ -398,14 +398,24 @@ protected Option<Pair<String, CompactionOperation>>
getPendingLogCompactionOpera
@Override
protected boolean isPartitionAvailableInStore(String partitionPath) {
- return partitionToFileGroupsMap.containsKey(partitionPath);
+ try {
+ readLock.lock();
+ return partitionToFileGroupsMap.containsKey(partitionPath);
Review Comment:
I don't think this is actually accurate. If you move the locks closer to the
places that the access happens you can improve the throughput for the class. By
saying you can only use locks in public methods, you really limit yourself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
