vinothchandar commented on a change in pull request #2136:
URL: https://github.com/apache/hudi/pull/2136#discussion_r513620662
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/upgrade/AbstractUpgradeDowngrade.java
##########
@@ -132,6 +134,8 @@ protected void run(HoodieTableVersion toVersion, String
instantTime) throws IOEx
}
private void createUpdatedFile(Properties props) throws IOException {
+ DefaultHoodieConfig.setDefaultOnCondition(props,
!props.containsKey(HoodieIndexConfig.INDEX_TYPE_PROP),
Review comment:
but should we persist the configured index type as opposed to the
default? they can be different right
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]