vinothchandar commented on a change in pull request #2136:
URL: https://github.com/apache/hudi/pull/2136#discussion_r513622049
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/AbstractHoodieClient.java
##########
@@ -124,9 +128,30 @@ public HoodieWriteConfig getConfig() {
return config;
}
+ private void checkIndexTypeCompatible(String writeIndexType, String
persistIndexType) {
+ if (writeIndexType.equals(persistIndexType)) {
+ return;
+ } else {
+ if ((persistIndexType.equals(HoodieIndex.IndexType.GLOBAL_BLOOM.name())
+ && (writeIndexType.equals(HoodieIndex.IndexType.BLOOM.name()) ||
writeIndexType.equals(HoodieIndex.IndexType.SIMPLE.name())))
+ || writeIndexType.equals(HoodieIndex.IndexType.INMEMORY.name())) {
+ return;
+ } else {
+ throw new HoodieException("The new write indextype " + writeIndexType
Review comment:
Not following the last sentence. but high level, we are on the same page
I think. I was suggesting `CUSTOM` as the indexType() when its user supplied
class. we can make the compatibility check such that custom is not compatible
with anything else.
I think you are suggesting to persist the index class as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
