alexr17 commented on code in PR #13103:
URL: https://github.com/apache/hudi/pull/13103#discussion_r2036342523
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/lock/StorageBasedLockConfig.java:
##########
@@ -28,53 +28,54 @@
import java.util.concurrent.TimeUnit;
import static org.apache.hudi.common.config.HoodieCommonConfig.BASE_PATH;
-import static
org.apache.hudi.client.transaction.lock.ConditionalWriteLockProvider.DEFAULT_TABLE_LOCK_FILE_NAME;
+import static
org.apache.hudi.client.transaction.lock.StorageBasedLockProvider.DEFAULT_TABLE_LOCK_FILE_NAME;
import static
org.apache.hudi.common.table.HoodieTableMetaClient.LOCKS_FOLDER_NAME;
-public class ConditionalWriteLockConfig extends HoodieConfig {
+public class StorageBasedLockConfig extends HoodieConfig {
private static final String SINCE_VERSION_1_0_2 = "1.0.2";
- private static final String CONDITIONAL_WRITE_LOCK_PROPERTY_PREFIX =
LockConfiguration.LOCK_PREFIX
- + "conditional_write.";
+ private static final String STORAGE_BASED_LOCK_PROPERTY_PREFIX =
LockConfiguration.LOCK_PREFIX
+ + "storage";
public static final ConfigProperty<String> LOCK_INTERNAL_STORAGE_LOCATION =
ConfigProperty
- .key(CONDITIONAL_WRITE_LOCK_PROPERTY_PREFIX + "locks_location")
+ .key(STORAGE_BASED_LOCK_PROPERTY_PREFIX + "locks_location")
.defaultValue("")
.markAdvanced()
.sinceVersion(SINCE_VERSION_1_0_2)
.withDocumentation(
"For storage-based lock provider, the optional URI where lock files
are written. "
- + "For example, if `/lock/location` is specified,
`/lock/location/<lock_file_name>` is used as the lock file, where the lock file
name `lock_file_name` is determined based on the table's base path. "
+ + "For example, if `/lock/location` is specified,
`/lock/location/<lock_file_name>` is used as the lock file,"
+ + "where the lock file name `lock_file_name` is determined based
on the table's base path. "
+ "Must be the same filesystem as the table path and should
support conditional writes. "
+ "By default, writes to " + LOCKS_FOLDER_NAME + Path.SEPARATOR
+ DEFAULT_TABLE_LOCK_FILE_NAME + ".json under the table base
path.");
- public static final ConfigProperty<Long> LOCK_VALIDITY_TIMEOUT_MS =
ConfigProperty
- .key(CONDITIONAL_WRITE_LOCK_PROPERTY_PREFIX + "validity.timeout.ms")
- .defaultValue(TimeUnit.MINUTES.toMillis(5))
+ public static final ConfigProperty<Long> LOCK_VALIDITY_TIMEOUT =
ConfigProperty
+ .key(STORAGE_BASED_LOCK_PROPERTY_PREFIX + "validity.timeout")
+ .defaultValue(TimeUnit.MINUTES.toSeconds(5))
.markAdvanced()
.sinceVersion(SINCE_VERSION_1_0_2)
.withDocumentation(
- "For storage-based lock provider, the amount of time each new lock
is valid for. "
+ "For storage-based lock provider, the amount of time in seconds each
new lock is valid for. "
+ "The lock provider will attempt to renew its lock until it
successfully extends the lock lease period "
+ "or the validity timeout is reached.");
- public static final ConfigProperty<Long> HEARTBEAT_POLL_MS = ConfigProperty
- .key(CONDITIONAL_WRITE_LOCK_PROPERTY_PREFIX + "heartbeat.poll.ms")
- .defaultValue(TimeUnit.SECONDS.toMillis(30))
+ public static final ConfigProperty<Long> HEARTBEAT_POLL = ConfigProperty
+ .key(STORAGE_BASED_LOCK_PROPERTY_PREFIX + "heartbeat.poll")
Review Comment:
hoodie.write.lock.storage.heartbeat.poll
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
