danny0405 commented on code in PR #13103:
URL: https://github.com/apache/hudi/pull/13103#discussion_r2036346895
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/lock/StorageBasedLockProvider.java:
##########
@@ -293,42 +281,25 @@ public synchronized boolean tryLock() {
Pair<LockGetResult, StorageLockFile> latestLock =
this.lockService.readCurrentLockFile();
if (latestLock.getLeft() == LockGetResult.UNKNOWN_ERROR) {
- logger.info(
- LOCK_STATE_LOGGER_MSG_WITH_INFO,
- ownerId,
- lockFilePath,
- Thread.currentThread(),
- FAILED_TO_ACQUIRE,
- "Failed to get the latest lock status");
+ logInfoLockState(FAILED_TO_ACQUIRE, "Failed to get the latest lock
status");
// We were not able to determine whether a lock was present.
return false;
}
if (latestLock.getLeft() == LockGetResult.SUCCESS &&
isLockStillValid(latestLock.getRight())) {
String msg = String.format("Lock already held by %s",
latestLock.getRight().getOwner());
// Lock held by others.
Review Comment:
should we validate the holder UUID here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
