linliu-code commented on code in PR #13115:
URL: https://github.com/apache/hudi/pull/13115#discussion_r2037943933
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/FileGroupRecordBuffer.java:
##########
@@ -341,17 +344,18 @@ protected Option<Pair<Option<T>, Map<String, Object>>>
doProcessNextDataRecord(T
/**
* Merge a delete record with another record (data, or delete).
*
- * @param deleteRecord
- * @param existingRecordMetadataPair
- * @return
+ * @param deleteRecord The delete record
+ * @param existingRecordMetadataPair The existing record metadata pair
+ *
+ * @return The option of new delete record that needs to be updated with.
*/
protected Option<DeleteRecord> doProcessNextDeletedRecord(DeleteRecord
deleteRecord,
Pair<Option<T>,
Map<String, Object>> existingRecordMetadataPair) {
totalLogRecords++;
if (existingRecordMetadataPair != null) {
switch (recordMergeMode) {
case COMMIT_TIME_ORDERING:
- return Option.empty();
+ return Option.of(deleteRecord);
Review Comment:
We should have many functional tests accessing this path. But for unit
tests, we probably don't.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
