linliu-code commented on code in PR #13115:
URL: https://github.com/apache/hudi/pull/13115#discussion_r2037952330
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/FileGroupRecordBuffer.java:
##########
@@ -233,11 +233,12 @@ public void close() {
/**
* Merge two log data records if needed.
*
- * @param record
- * @param metadata
- * @param existingRecordMetadataPair
- * @return
- * @throws IOException
+ * @param record The record
+ * @param metadata The metadata
+ * @param existingRecordMetadataPair The existing record metadata pair
+ *
+ * @return The pair of the record that needs to be updated with and its
metadata,
+ * returns empty to skip the update.
Review Comment:
Here new records can not be a delete record; since records with delete
markers have been routed to a different path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
