nsivabalan commented on PR #13126: URL: https://github.com/apache/hudi/pull/13126#issuecomment-2798102051
Few more feedback that needs to be addressed: 1. https://github.com/apache/hudi/pull/13126/files#r2038561912 2. For the missing region issue, why can't we just go ahead and instantiate S3 client and then make below call to get the region and reinstantiate s3 client if need be. GetBucketLocationResponse bucketLocationResponse = s3Client.getBucketLocation(GetBucketLocationRequest.builder().bucket(bucketName).build()); String bucketRegion = bucketLocationResponse.locationConstraint().toString(); 3. https://github.com/apache/hudi/pull/13126/files#r2038581765 4. https://github.com/apache/hudi/pull/13126/files#r2038585276 5. StorageLockService StorageLockClient. var naming in StorageSchemes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
