danny0405 commented on code in PR #13126:
URL: https://github.com/apache/hudi/pull/13126#discussion_r2041290167
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/lock/StorageBasedLockProvider.java:
##########
@@ -65,15 +66,14 @@
/**
* A distributed filesystem storage based lock provider. This {@link
LockProvider} implementation
* leverages conditional writes to ensure transactional consistency for
multi-writer scenarios.
- * The underlying storage client interface {@link StorageLock} is pluggable so
it can be implemented for any
+ * The underlying storage client interface {@link StorageLockClient} is
pluggable so it can be implemented for any
* filesystem which supports conditional writes.
*/
@ThreadSafe
public class StorageBasedLockProvider implements LockProvider<StorageLockFile>
{
- public static final String DEFAULT_TABLE_LOCK_FILE_NAME = "table_lock";
+ public static final String DEFAULT_TABLE_LOCK_FILE_NAME = "table_lock.json";
// How long to wait before retrying lock acquisition in blocking calls.
- private static final long DEFAULT_LOCK_ACQUISITION_BUFFER_MS = 1000;
Review Comment:
delete the comment in line 76 too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
