yihua commented on code in PR #13171:
URL: https://github.com/apache/hudi/pull/13171#discussion_r2054525263
##########
hudi-hadoop-common/src/test/java/org/apache/hudi/common/table/read/TestCustomMerger.java:
##########
@@ -182,6 +180,7 @@ public void testWithThreeLogFiles(boolean
useRecordPositions) throws IOException
@Test
public void testWithFourLogFiles() throws IOException, InterruptedException {
+ shouldWritePositions = Arrays.asList(false, false, false, false, false);
Review Comment:
If we plan to replace these tests, there is no need to change this now. The
reason I brought this up is that other tests are parameterized on
`useRecordPositions` (e.g., `testWithThreeLogFiles(boolean
useRecordPositions)`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
