the-other-tim-brown commented on code in PR #13171:
URL: https://github.com/apache/hudi/pull/13171#discussion_r2054552581
##########
hudi-hadoop-common/src/test/java/org/apache/hudi/common/table/read/TestCustomMerger.java:
##########
@@ -182,6 +180,7 @@ public void testWithThreeLogFiles(boolean
useRecordPositions) throws IOException
@Test
public void testWithFourLogFiles() throws IOException, InterruptedException {
+ shouldWritePositions = Arrays.asList(false, false, false, false, false);
Review Comment:
The positional based lookup and fallback logic is not at all related to the
CustomMerger so these tests need to be moved to a class that just tests the
record buffer lookup/fallback
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
