TheR1sing3un commented on code in PR #13192:
URL: https://github.com/apache/hudi/pull/13192#discussion_r2055148411
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/clean/CleanActionExecutor.java:
##########
@@ -257,7 +257,8 @@ public HoodieCleanMetadata execute() {
}
for (HoodieInstant hoodieInstant : pendingCleanInstants) {
- if (table.getCleanTimeline().isEmpty(hoodieInstant)) {
+ if
(table.getCleanTimeline().isEmpty(CleanerUtils.getCleanRequestInstant(table.getMetaClient(),
hoodieInstant))) {
+ // remove the empty instant
Review Comment:
> we also need to delete the empty inflight file?
The original logic here is to delete the inflight file. I think what you
should be saying is whether we also need to delete the request file, right?
I originally attempted to make this change, but I found that it would
disrupt the existing ut logic, you can refer to my previous commit:
https://github.com/apache/hudi/pull/13192/commits/16230a47b0dfd3433f764d8fe94bbbd959c9db9c.
To reduce the unknown risks brought by the change, this change only makes
alterations to the way the plan is obtained and does not change any other logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
