TheR1sing3un commented on code in PR #13192:
URL: https://github.com/apache/hudi/pull/13192#discussion_r2055150539
##########
hudi-common/src/main/java/org/apache/hudi/common/util/CleanerUtils.java:
##########
@@ -168,10 +168,18 @@ public static Option<HoodieInstant>
getEarliestCommitToRetain(
public static HoodieCleanerPlan getCleanerPlan(HoodieTableMetaClient
metaClient, HoodieInstant cleanInstant)
throws IOException {
CleanPlanMigrator cleanPlanMigrator = new CleanPlanMigrator(metaClient);
+ cleanInstant = getCleanRequestInstant(metaClient, cleanInstant);
Review Comment:
> can we make the `cleanInstant` as `REQUESTED` from the invoker?
The current invoker does not care whether the incoming Instant is request or
inflight. To be compatible with the current usage logic of invoker, I choose to
perform the instant conversion at this method. Moreover, from the design of
this method itself, given a clean instant of any state, It is reasonable that
we should all be able to return to the correct plan.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
