the-other-tim-brown commented on code in PR #13208:
URL: https://github.com/apache/hudi/pull/13208#discussion_r2056176952
##########
hudi-common/src/main/java/org/apache/hudi/common/engine/HoodieReaderContext.java:
##########
@@ -243,10 +263,7 @@ public boolean castToBoolean(Object value) {
* @param schema The Avro schema of the record.
* @return The record key in String.
*/
- public String getRecordKey(T record, Schema schema) {
- Object val = getValue(record, schema, RECORD_KEY_METADATA_FIELD);
- return val.toString();
- }
+ public abstract String getRecordKey(T record, Schema schema);
Review Comment:
Good idea, switching to this pattern in the next commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
