yihua commented on code in PR #13208:
URL: https://github.com/apache/hudi/pull/13208#discussion_r2056755454
##########
hudi-common/src/main/java/org/apache/hudi/keygen/constant/KeyGeneratorType.java:
##########
@@ -150,4 +150,12 @@ public static String getKeyGeneratorClassName(Map<String,
String> config) {
}
return null;
}
+
+ public KeyGeneratorType getAvroImplementation() {
+ if (name().endsWith("AVRO")) {
+ return this;
+ }
+ String avroName = name() + "_AVRO";
+ return KeyGeneratorType.valueOf(avroName);
Review Comment:
So is the class checked before trying to load it? Also should
`HoodieTableMetadataKeyGenerator` be moved to `hudi-common` module, if the
support of reading MDT goes through the file group reader (MDT does not
populate meta fields)? Another option is to remove
`HoodieTableMetadataKeyGenerator` since it's simple keygen with hardcoded key
field name and partition path value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
