danny0405 commented on code in PR #13178:
URL: https://github.com/apache/hudi/pull/13178#discussion_r2057527407


##########
hudi-hadoop-common/src/main/java/org/apache/hudi/io/hadoop/HoodieHBaseAvroHFileReader.java:
##########
@@ -628,6 +628,8 @@ public boolean hasNext() {
       try {
         // NOTE: This is required for idempotency
         if (eof) {
+          // eagerly close
+          close();

Review Comment:
   we have these eagerly close, do we still need to invoke the `Iterator.close` 
outside?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to