danny0405 commented on code in PR #13178:
URL: https://github.com/apache/hudi/pull/13178#discussion_r2059406934
##########
hudi-hadoop-common/src/main/java/org/apache/hudi/io/hadoop/HoodieHBaseAvroHFileReader.java:
##########
@@ -628,6 +628,8 @@ public boolean hasNext() {
try {
// NOTE: This is required for idempotency
if (eof) {
+ // eagerly close
+ close();
Review Comment:
yeah, understand, but eager close is not often used in code, I suggest we
remove it and unify the code to `AutoClosable` and `try-resource` for resource
releasing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
