yihua commented on code in PR #13208:
URL: https://github.com/apache/hudi/pull/13208#discussion_r2059079634
##########
hudi-common/src/main/java/org/apache/hudi/keygen/KeyGenerator.java:
##########
@@ -56,4 +61,35 @@ public List<String> getRecordKeyFieldNames() {
throw new UnsupportedOperationException("Bootstrap not supported for key
generator. "
+ "Please override this method in your custom key generator.");
}
+
+ public static String constructRecordKey(List<String> recordKeyFields,
List<Object> recordKeyValues) {
Review Comment:
nit: change this to take `List<Pair<String, Object>>
recordKeyFieldAndValueList` so we don't have to worry that the list size does
not match or invocation with mismatched list?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
