yihua commented on code in PR #13208:
URL: https://github.com/apache/hudi/pull/13208#discussion_r2059151584
##########
hudi-common/src/main/java/org/apache/hudi/keygen/KeyGenerator.java:
##########
@@ -56,4 +61,35 @@ public List<String> getRecordKeyFieldNames() {
throw new UnsupportedOperationException("Bootstrap not supported for key
generator. "
+ "Please override this method in your custom key generator.");
}
+
+ public static String constructRecordKey(List<String> recordKeyFields,
List<Object> recordKeyValues) {
+ if (recordKeyFields.size() == 1) {
Review Comment:
We could also possibly get rid of this check by having another
`constructRecordKey` method on a single field since the reader context knows
the number of fields during initialization, so this check only lives in the
constructor of the reader context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
