the-other-tim-brown commented on code in PR #13208:
URL: https://github.com/apache/hudi/pull/13208#discussion_r2059190489
##########
hudi-common/src/main/java/org/apache/hudi/keygen/KeyGenerator.java:
##########
@@ -56,4 +61,35 @@ public List<String> getRecordKeyFieldNames() {
throw new UnsupportedOperationException("Bootstrap not supported for key
generator. "
+ "Please override this method in your custom key generator.");
}
+
+ public static String constructRecordKey(List<String> recordKeyFields,
List<Object> recordKeyValues) {
+ if (recordKeyFields.size() == 1) {
Review Comment:
This is feeling like a large micro optimization, with branch prediction this
may not be that big of a win and this is for a case we're considering
deprecating (virtual keys)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
