nsivabalan commented on code in PR #13229:
URL: https://github.com/apache/hudi/pull/13229#discussion_r2078718906
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -1510,7 +1514,7 @@ protected HoodieData<HoodieRecord>
prepRecords(Map<String, HoodieData<HoodieReco
public void performTableServices(Option<String> inFlightInstantTimestamp,
boolean requiresTimelineRefresh) {
HoodieTimer metadataTableServicesTimer = HoodieTimer.start();
boolean allTableServicesExecutedSuccessfullyOrSkipped = true;
- BaseHoodieWriteClient<?, I, ?, ?> writeClient = getWriteClient();
+ BaseHoodieWriteClient<?, I, ?, O> writeClient = getWriteClient();
Review Comment:
yes. we have to do writeClient.commit followed by
writeClient.bulkInsertPrepped or writeclient.upsertPrepped now w/ metadata
table.
So we have introduced method
bulkInsertAndCommit
which engine specific class will override(like
SparkHoodieBackedTableMetadataWriter).
```
protected void bulkInsertAndCommit(BaseHoodieWriteClient<?,
JavaRDD<HoodieRecord>, ?, JavaRDD<WriteStatus>> writeClient, String
instantTime, JavaRDD<HoodieRecord> preppedRecordInputs,
Option<BulkInsertPartitioner>
bulkInsertPartitioner) {
JavaRDD<WriteStatus> writeStatusJavaRDD =
writeClient.bulkInsertPreppedRecords(preppedRecordInputs, instantTime,
bulkInsertPartitioner);
writeClient.commit(instantTime, writeStatusJavaRDD, Option.empty(),
DELTA_COMMIT_ACTION, Collections.emptyMap());
}
```
So, the return value of writeClient.upsert refers to JavaRDD<WriteStatus>
and so we have to migrate from "?" to "O"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
